openfast icon indicating copy to clipboard operation
openfast copied to clipboard

Published 20 hours ago • verified publisher icon OpenFAST

Bug fix: BEMT was disabled for negative inflow

Open bjonkman opened this issue 2 years ago • 1 comments

Feature or improvement description The check to turn off BEM for low TSRs should have been using ABS(TSR) instead of TSR so that BEM is not disabled for all negative TSR values.

Related issue, if one exists https://github.com/OpenFAST/openfast/discussions/940

Impacted areas of the software AeroDyn

Additional supporting information

Test results, if applicable Tests where TSR < -1.5 will have differences due to BEM now turning back on at that point.

AD Timeseries Shutdown case (AD driver): bokeh_plot(4) bokeh_plot(3)

ad_timeseries_shutdown

AD BAR RNA motion case (AD driver): bokeh_plot(2) bokeh_plot(1) ad_BAR_RNAmotion

bjonkman avatar Mar 09 '22 00:03 bjonkman

Merge this around the same time we do PR #932

andrew-platt avatar Mar 09 '22 15:03 andrew-platt

@bjonkman could you update the r-test commit here to 1db296f2? I can push to your branch from the GitHub web editor but not from my command line, so I can't make the change to r-test directly.

rafmudaf avatar Sep 20 '22 22:09 rafmudaf

Actually, it looks like you also updated the r-test commit previously. I've updated the AeroDyn cases that are currently failing in 1db296f2. If I'm understanding the state of this pull request correctly, you could cherry pick that commit to your r-test branch.

rafmudaf avatar Sep 20 '22 22:09 rafmudaf

Actually, it looks like you also updated the r-test commit previously.

That "update" was just to get the submodule to point to the most recent dev commit, which it should have done when I merged the branch (on the next commit). I just did an extra commit because the submodule initialization was being a pain on my computer today.

Anyway, it should be pointing to your updated r-test commit now. Thanks for updating it!

bjonkman avatar Sep 20 '22 23:09 bjonkman