ontology icon indicating copy to clipboard operation
ontology copied to clipboard

Add `industrial technology` and `industrial plant`

Open l-emele opened this issue 1 year ago • 3 comments

Summary of the discussion

Describe the findings of the discussion in the issue or meeting.

Type of change (CHANGELOG.md)

Add

  • Added a new class #

Update

  • Updated a definition #

Remove

  • Removed a broken link #

Workflow checklist

Automation

Closes #1726

PR-Assignee

Reviewer

  • [ ] 🐙 Follow the Reviewer Guide
  • [ ] 🐙 Provided feedback and show sufficient appreciation for the work done

l-emele avatar Apr 19 '24 09:04 l-emele

What is the state of this PR? Can you finish it until the release @l-emele?

stap-m avatar May 02 '24 10:05 stap-m

What is the state of this PR? Can you finish it until the release @l-emele?

I don't think so. My implementation has led to some inconsistencies (see failing CI run). The problem is that classes introduced at different stages do not align, see issue discussion. I don't see a quick fix for this.

l-emele avatar May 06 '24 07:05 l-emele

I implemented the industry technology axiom wrong and that is why the CI was failing. I fixed this and it is now working again.

However, I want to discuss some further things related to the industry classes, see issue #1726.

l-emele avatar Jun 25 '24 16:06 l-emele

@stap-m : I think I've implemented everything as discussed today. So this PR is now (again) ready for review.

l-emele avatar Aug 22 '24 12:08 l-emele