ontology icon indicating copy to clipboard operation
ontology copied to clipboard

import `characteristic of` from RO

Open stap-m opened this issue 2 years ago • 8 comments

Description of the issue

We currently import has characteristic from RO, but not its inverse characteristic of. Instead we defined our own relation has bearer. It is good practice to reuse extisting relations and terms, especially from well-established and widely used ontologies like RO. Therefore, we should think about replacing has bearer with characteristic of.

Workflow checklist

  • [ ] I discussed the issue with someone else than me before working on a solution
  • [ ] I already read the latest version of the workflow for this repository
  • [ ] The goal of this ontology is clear to me

I am aware that

  • [ ] every entry in the ontology should have a definition
  • [ ] classes should arise from concepts rather than from words

stap-m avatar Jan 09 '24 13:01 stap-m

I agree that we should import characteristic of from RO. But as has bearer is currently used more than 100 times I suggest that we do no replace our has bearer with characteristic of but instead declare has bearer as equivalent to characteristic of. This avoids the tedious work of adapting so many axioms.

l-emele avatar Jan 09 '24 13:01 l-emele

Maybe we should import this whole branch of object properties: grafik

l-emele avatar Feb 01 '24 07:02 l-emele

I agree that we should import characteristic of from RO. But as has bearer is currently used more than 100 times I suggest that we do no replace our has bearer with characteristic of but instead declare has bearer as equivalent to characteristic of. This avoids the tedious work of adapting so many axioms.

I think this is rather a find-and-replace job and managable. But we can discuss this in a meeting.

stap-m avatar Feb 06 '24 10:02 stap-m

I think this is rather a find-and-replace job and managable. But we can discuss this in a meeting.

Only if you neglect the term trackers... It put in on the agenda for the next OEO dev meeting.

l-emele avatar Feb 07 '24 08:02 l-emele

From Dev meeting 76:

Aufgaben:

  • Import "characteristic of" from RO with subproperties
  • disposition of
  • function of
  • quality of
  • role of
  • Add equivalence with "has bearer"

  • Replace?

    Wer macht es? @areleu (@stap-m , kannst du unterstützen und nochmal den workflow erklären?)

areleu avatar Mar 21 '24 09:03 areleu

I can do the import and you do the integration/mapping within OEO @areleu?

stap-m avatar Mar 21 '24 10:03 stap-m

I can do the import and you do the integration/mapping within OEO @areleu?

Sure, I also wanted to understand how should the oeo-tools used now. Should it be cloned inside the OEO repo?

areleu avatar Mar 21 '24 10:03 areleu

Ok. Here's the workflow

  1. Update list of terms to be imported in oeo-tools repo
  2. Run script in oeo-tools repo
  3. PR in oeo-tools repo
  4. Copy xxx-extracted.owl to oeo-repo and check new import in oeo
  5. PR in oeo repo
  6. Reference PRs and issues in both repos for transparency.

stap-m avatar Mar 22 '24 08:03 stap-m