ontology icon indicating copy to clipboard operation
ontology copied to clipboard

[meta] review RO imports and (conservative?) extensions

Open stap-m opened this issue 1 year ago • 1 comments

Description of the issue

Background

  • in #617 / #1019 we added domains and ranges to imported RO relations since they were not included in the import
  • in #1268 we updated the import process for RO
  • in #1592 and #1754 we updated the structure of the file imports

Current state / ToDos:

  • [ ] OEO proper RO extensions (annotations and axioms to RO-imports) are scattered around OEO (mainly in oeo-shared, probably)
  • [ ] Since the import process changed, we have to check, whether RO relations don't have proper domains and rages, OR whether we don't want / are not able to import them
  • [ ] Think about the right way of extending (conservatively) RO imports without changing the relations semantically

Ideas of solution

If you already have ideas for the solution describe them here

Workflow checklist

  • [ ] I discussed the issue with someone else than me before working on a solution
  • [ ] I already read the latest version of the workflow for this repository
  • [ ] The goal of this ontology is clear to me

I am aware that

  • [ ] every entry in the ontology should have a definition
  • [ ] classes should arise from concepts rather than from words

stap-m avatar Dec 05 '23 14:12 stap-m

For ease of discussion, here an overview of the current differences between ranges & domains in the RO vs how they are imported in the OEO:

Class Domain in RO Domain in OEO import Range in RO Range in OEO import
BFO_0000054 (realized in) realizable entity process
RO_0003001 (produced by) material entity material entity
RO_0003000 (produces) material entity material entity
BFO_0000062 (preceded by) occurrent occurrent
BFO_0000063 (precedes) occurrent occurrent
RO_0002091 (starts during) occurrent occurrent
RO_0000053 (has characteristic/bearer of) energy or independent continuant specifically dependent continuant specifically dependent continuant
RO_0000087 (has role) independent continuant energy or idependent continuant role role
RO_0000086 (has quality) continuant quality quality
RO_0001025 (located in) independent continuant and (not (spatial region))* independent continuant independent continuant and (not (spatial region))* independent continuant
RO_0002501 (causal relation between processes) occurent process occurent process
RO_0002410 (causally related to) process or material entity process or material entity

*Note: The RO also contains a redundant axiom listing "independent continuant" seperately here, specifically to make the RO easier to use with reasoners that cannot handle negation

Most of the domains/ranges are defined in oeo-import-edits, however RO_0000053 (bearer of) and RO_0002410 (causally related to) have their domains and ranges defined in oeo-shared, and while the range of RO_0000087 (has role) is defined in oeo-import-edits, its domain is defined in oeo-shared. As an additional note: "has input" used to have a defined range within the OEO (for reference see pull request 702), but this axiom is now missing. If this was a deliberate decision, the discussion should probably be added to the term tracker.

h-spinde avatar Mar 27 '24 08:03 h-spinde