ontology icon indicating copy to clipboard operation
ontology copied to clipboard

OEO Import Structures

Open h-spinde opened this issue 2 years ago • 8 comments

Description of the issue

Currently, which file in the OEO imports which is a little confusing, with some files even being imported into multiple different other ones. The structure currently looks like this: oeo-import-structure.pdf

Ideas of solution

There should be some agreement over where each file should be imported into the OEO, so that the structure can be more intuitively understood and redundant imports can be avoided. Ideally, the diagram in the wiki under Modules of the OEO should also reflect the import structure.

Workflow checklist

  • [ ] I discussed the issue with someone else than me before working on a solution
  • [x] I already read the latest version of the workflow for this repository
  • [x] The goal of this ontology is clear to me

h-spinde avatar Nov 20 '23 10:11 h-spinde

I agree that the current structure is confusing. The file readme.md contains this diagram after our large restructuring in issue #1592 for release 2.0.0:

Structure of the OEO

This is much cleaner and should work, too. I don't see a reason why a module is imported multiple times. Also imho oeo-physical-axioms should be imported directly to oeo-physical as it extends that module, but is irrelevant for the other modules.

l-emele avatar Nov 20 '23 12:11 l-emele

This is much cleaner and should work, too. I don't see a reason why a module is imported multiple times. Also imho oeo-physical-axioms should be imported directly to oeo-physical as it extends that module, but is irrelevant for the other modules.

@l-emele unfortunately, the figure in README / wiki is currently not the actual state, but the one prepared by @h-spinde.

I started testing an untangling process (see figure below) by importing oeo-import-edits into oeo-shared directly and by deleting omo-extracted (since redundant, based on #1755) in #1754.
@l-emele @h-spinde @nelekoehler @areleu could someone please check the current PR for inconsistencies?

grafik

stap-m avatar Nov 21 '23 11:11 stap-m

@l-emele unfortunately, the figure in README / wiki is currently not the actual state, but the one prepared by @h-spinde.

Ys, I know. But it depicts very well how the import structure should be. That is why I referenced it.

l-emele avatar Nov 21 '23 11:11 l-emele

@l-emele @h-spinde @nelekoehler @areleu could someone please check the current PR for inconsistencies?

I checked: In the PR branch OMO-defined annotations do not exist anymore. But we did not use them anyway.

l-emele avatar Nov 21 '23 11:11 l-emele

As you are updating the import structure, this seems also the right time to harmonise prefixes across ontology files, see issue #1651.

l-emele avatar Nov 21 '23 17:11 l-emele

I now also removed the redundant BFO import.

stap-m avatar Nov 23 '23 11:11 stap-m

Partially solved by #1754 I move it to the next milestone for the remaining parts.

stap-m avatar Dec 01 '23 10:12 stap-m

@areleu can we implement a test for imports that checks whether a certain class was already imported before (by another ontolotgy import), to avoid duplicate imports?

stap-m avatar Apr 24 '24 06:04 stap-m