ontology icon indicating copy to clipboard operation
ontology copied to clipboard

Feature 1301 tank

Open lumi321 opened this issue 2 years ago • 1 comments

Summary of the discussion

Add tank and fuel tank together with volume.

Type of change (CHANGELOG.md)

Added

  • Added tank: A tank is an artificial object that stores a liquid or gaseous portion of matter.
  • Added fuel tank: A fuel tank is a tank that stores a combustion fuel.
  • Added volume: A volume is a quantity value indicating the size of a three-dimensional spatial region.

Axioms:

  • 'tank' 'has quantity value' some volume
  • 'fuel tank' 'has quantity value' some 'storage capacity'
  • 'fuel tank' 'has function' some 'chemical energy storage function'
  • volume 'has unit' some 'volume unit'
  • volume 'quantity value of' some 'three-dimensional spatial region'

Updated

  • 'internal combustion vehicle' 'has part' some 'fuel tank'
  • 'plug-in hybrid electric vehicle' 'has part' some 'fuel tank'
  • 'fuel cell electric vehicle' 'has part' some 'fuel tank'
  • 'tank ship' 'has part' some 'tank'
  • 'gas turbine vehicle' 'has part' some ''fuel tank'

Workflow checklist

Automation

Closes #1301

PR-Assignee

Reviewer

  • [ ] 🐙 Follow the Reviewer Guide
  • [ ] 🐙 Provided feedback and show sufficient appreciation for the work done

lumi321 avatar Oct 26 '22 09:10 lumi321

In order to implement the axiom 'fuel tank' 'has function' some 'chemical energy storage function', the PR #1348 needs to be merged first.

lumi321 avatar Oct 26 '22 09:10 lumi321

Looks good so far. I did a minor change to CHANGELOG.md: Ideally, a class is only mentioned once in the changed section.

l-emele avatar Oct 28 '22 08:10 l-emele

@lumi321 #1348 is merged now.

stap-m avatar Oct 31 '22 19:10 stap-m

Thank you!

lumi321 avatar Nov 07 '22 10:11 lumi321