ontology icon indicating copy to clipboard operation
ontology copied to clipboard

Added definition to individuals of boolean values

Open rue-l opened this issue 2 years ago • 3 comments

Summary of the discussion

To assure that the naming is not ambiguous a definition for each individual is needed.

Type of change (CHANGELOG.md)

Added

  • todo

Workflow checklist

Automation

Closes #1148

PR-Assignee

Reviewer

  • [ ] 🐙 Follow the Reviewer Guide
  • [ ] 🐙 Provided feedback and show sufficient appreciation for the work done

rue-l avatar Jul 21 '22 12:07 rue-l

Thanks for implementing. Please also take a look at this nice description for the PR workflow, that might help: https://github.com/OpenEnergyPlatform/ontology/wiki/Pull-request-workflow

stap-m avatar Jul 21 '22 13:07 stap-m

Looking again on this issue: Are true and false even instances/individuals of a boolean variable? Aren't these rather values of a boolean variable?

Originally posted by @l-emele in https://github.com/OpenEnergyPlatform/ontology/issues/1148#issuecomment-1202256982

l-emele avatar Aug 16 '22 08:08 l-emele

I copied the PR-template to the first issue to follow the workflow.

Ludee avatar Sep 22 '22 09:09 Ludee

I reset this PR to draft as we do not have a solution, see issue.

l-emele avatar Apr 21 '23 06:04 l-emele

As for the question value or instance. I think there is no difference; values are the instances of primitive types when viewed as classes. It is more a technical discrimination between primitve types and classes because it is easier/faster to have copies - say for the age 26 of a person and the distance 26 km between Karlsruhe and Rastatt, respectively. This is better than linking to a one and only memory address with the value 26 that could represent this instance of the class Integer - and may be referenced a Googol times. But another difference can be introduced: primitive type classes do not have an identifier, other classes have one and this allows to have instances which are not distinguishable by the values of their properties cause they are all the same - their special property identifier makes the difference. So, a Boolean is a class with one-bit values and therefore just two instances are possible: true and false which are coded by bit 1 and 0.

UStucky avatar Jun 15 '23 13:06 UStucky

I've now implemented what was discussed in the issue and it is now ready for review.

l-emele avatar Jun 16 '23 11:06 l-emele