OED icon indicating copy to clipboard operation
OED copied to clipboard

Default meter select

Open nneni opened this issue 1 year ago • 3 comments

Description

Fixes #1186

Utilized React's useEffect hook to manage which option is selected when there is only one option (the only available choice, by default).

Type of change

  • [ x] Note merging this changes the database configuration.
  • [ ] This change requires a documentation update

Checklist

  • [ x] I have followed the OED pull request ideas
  • [ x] I have removed text in ( ) from the issue request
  • [ x] You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

None, at first the code was too specific and only applied to one of the data categories but after reanalysis it was rewritten to work in a more general sense.

nneni avatar Sep 30 '24 04:09 nneni

The code looks good, and very clear wit the functionality. it works and I'm personally not familiar with the nuances of react to determine if there is a better solution.

mmehta2669 avatar Oct 01 '24 21:10 mmehta2669

Everything looks good to me. Please convert this draft to PR.

Rakesh-Ranga-Buram avatar Oct 02 '24 00:10 Rakesh-Ranga-Buram

This is a note to be sure that PR #1314 does similar logic/effect or to get them in sync. This does not directly impact this PR.

huss avatar Oct 03 '24 14:10 huss

Thanks for catching those! Just made the edits and pushed them.

nneni avatar Oct 05 '24 19:10 nneni