OED icon indicating copy to clipboard operation
OED copied to clipboard

CSV Changes with Redux Toolkit and Formatting Updates

Open mikedivine opened this issue 1 year ago • 4 comments

Description

Removed CSV container and split into separate CSV pages. Uses Create Meter Modal in Readings and seems to be working with Redux.

@rfrost30 has helped contribute on this PR.

Fixes #1198

Type of change

  • [ ] Note merging this changes the database configuration.
  • [x] This change requires a documentation update

Checklist

  • [x] I have followed the OED pull request ideas
  • [x] I have removed text in ( ) from the issue request
  • [x] You acknowledge that every person contributing to this work has signed the [OED Contributing License Agreement]

Limitations

None

mikedivine avatar Jun 25 '24 00:06 mikedivine

I just pushed a commit to fix the pipeline test for identifier use and no create meter. It also fixes meter upload to consistently use identifier.

huss avatar Jul 12 '24 16:07 huss

I'm noting that I pushed two commits.

huss avatar Jul 22 '24 21:07 huss

I just merged in development since recent PRs caused a merge conflict and I had meant to do this PR earlier. I'll get it to work. After that there is one item unresolved that remains.

@mikedivine Can you look over the last comment and also verify my large merge did not cause an issue. My basic testing did not find any issues outside the last comment.

huss avatar Aug 04 '24 19:08 huss

I'm going to work with @mikedivine on the failed test to resolve meter name vs identifier.

huss avatar Aug 04 '24 20:08 huss