openems icon indicating copy to clipboard operation
openems copied to clipboard

Added GoodWe Charger PV 4 to 8 and changed/added calculation of power

Open Bockhorn-IT opened this issue 1 month ago • 3 comments

Added GoodWe Charger PV 4 to 8 and changed/added calculation of power instead of reading the power from register. For PV strings greater than number 4 there are no registers for the power, only for current and voltage, so we calculate them all instead.

Bockhorn-IT avatar Nov 26 '25 20:11 Bockhorn-IT

Codecov Report

:x: Patch coverage is 62.39316% with 44 lines in your changes missing coverage. Please review.

:x: Your patch check has failed because the patch coverage (62.40%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3444      +/-   ##
=============================================
+ Coverage      59.62%   59.64%   +0.02%     
  Complexity       112      112              
=============================================
  Files           2894     2899       +5     
  Lines         124658   124769     +111     
  Branches        9343     9355      +12     
=============================================
+ Hits           74318    74405      +87     
+ Misses         47522    47519       -3     
- Partials        2818     2845      +27     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 26 '25 20:11 codecov[bot]

The Tests are Failing right now aswell.

and forgot one file to commit, sorry

Bockhorn-IT avatar Nov 26 '25 23:11 Bockhorn-IT

Hi @Bockhorn-IT, nice to hear that this is working in your system.

Initially, we had nearly the same implementation, but our problem was that the GoodWe had inaccurate current values for each string. While measuring, a lot of test systems, we had total different current values even if the Nr. of Modules and the cardinal direction was the same, especially with low power. It would also be interesting to know what firmware your inverter has.

sebastianasen avatar Dec 03 '25 13:12 sebastianasen