openems
openems copied to clipboard
refactor: use Angular property binding for SVG fill attribute.
This PR replaces attr.fill="{{ fillRef }}" with [attr.fill]="fillRef" in SVG polygon bindings for improved Angular consistency and maintainability. The property binding syntax [attr.fill] is the standard Angular approach for dynamic attribute values, ensuring type safety, better template parsing, and alignment with the rest of the codebase.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
Additional details and impacted files
@@ Coverage Diff @@
## develop #3377 +/- ##
=============================================
+ Coverage 59.78% 59.86% +0.08%
Complexity 112 112
=============================================
Files 2785 2787 +2
Lines 120785 121037 +252
Branches 9015 9061 +46
=============================================
+ Hits 72205 72452 +247
+ Misses 45901 45869 -32
- Partials 2679 2716 +37
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Jasonlee6789 thanks. Looks good to me 👍