openems icon indicating copy to clipboard operation
openems copied to clipboard

Update readme.adoc: added docu how to use (ancillary costs)

Open sjjh opened this issue 6 months ago • 8 comments

See: https://community.openems.io/t/info-about-json-format-for-ancillary-costs-in-timeofusetarrif-entsoe/10261/3

sjjh avatar Jul 02 '25 20:07 sjjh

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3225      +/-   ##
===========================================
- Coverage    26.53%   26.48%   -0.04%     
===========================================
  Files          320      320              
  Lines         8641     8641              
  Branches      1334     1334              
===========================================
- Hits          2292     2288       -4     
- Misses        6245     6251       +6     
+ Partials       104      102       -2     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 02 '25 20:07 codecov[bot]

I believe after https://github.com/OpenEMS/openems/pull/3236/commits/397878c4787d3d221bedc8a4d58c8c4b2a389926 this PR needs to be updated. @venu-sagar can you suggest an updated sentence and link to how the manual definition of ancillary costs now works.

sjjh avatar Jul 13 '25 07:07 sjjh

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 16 '25 02:09 github-actions[bot]

@venu-sagar how can we progress here? :)

sjjh avatar Sep 16 '25 16:09 sjjh

@venu-sagar how can we progress here? :)

I was working on thr readme doc when i was working on the controller, but it was not complete back then. i took the initial points from you implementation and modified a bit and added the rest of the text. please have a look, feel free to add or modify any. please let me know once completed and ready to merge.

venu-sagar avatar Sep 17 '25 11:09 venu-sagar

Just read over the io.openems.edge.timeofusetariff.entsoe/readme.adoc file in the PR and it looks very readable/good to me. Thanks for your work! From my side, I'd be happy to get it merged as it is.

sjjh avatar Nov 02 '25 22:11 sjjh

Just read over the io.openems.edge.timeofusetariff.entsoe/readme.adoc file in the PR and it looks very readable/good to me. Thanks for your work! From my side, I'd be happy to get it merged as it is.

You should still male sure, that the Tests and Builds succeed - I do not know actually why the Validation Fails if you just Changed a Readme File?

Sn0w3y avatar Nov 02 '25 22:11 Sn0w3y

I do not know actually why the Validation Fails if you just Changed a Readme File?

Neither do I. The error seems to be in BackendApp.bndrun, thus I would naively assume that it is a false positive. Maybe @venu-sagar knows better.

sjjh avatar Nov 03 '25 21:11 sjjh