openems icon indicating copy to clipboard operation
openems copied to clipboard

Update IoShellyPro3Em.java: included remedy for communication error msg

Open sjjh opened this issue 6 months ago • 2 comments

Good error messages should contain information how to solve the issue, cf. https://www.nngroup.com/articles/error-message-guidelines/

sjjh avatar Jun 21 '25 11:06 sjjh

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3203      +/-   ##
=============================================
+ Coverage      58.87%   58.87%   +0.01%     
  Complexity       173      173              
=============================================
  Files           2619     2619              
  Lines         113027   113027              
  Branches        8318     8318              
=============================================
+ Hits           66536    66539       +3     
+ Misses         44000    43994       -6     
- Partials        2491     2494       +3     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 21 '25 11:06 codecov[bot]

As stated in https://github.com/OpenEMS/openems/issues/3205#issuecomment-2993788158 i would not just Inform the User in the Generic "Communication Failed" Channel as this is too Generic. It coul basically be EVERYTHING why it fails - so it woul be better to create a new Channel for this if we get a Status Code 401 from the Shelly Device. See the /shelly Endpoint

Sn0w3y avatar Jun 21 '25 21:06 Sn0w3y

obsolete due to #3248

sjjh avatar Jul 25 '25 16:07 sjjh