openems icon indicating copy to clipboard operation
openems copied to clipboard

feat: add edge-list to siderbar in UI

Open miettal opened this issue 7 months ago • 5 comments

Powerd by Codex!

miettal avatar Jun 02 '25 06:06 miettal

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3157   +/-   ##
==========================================
  Coverage           ?   61.95%           
  Complexity         ?      113           
==========================================
  Files              ?     2443           
  Lines              ?   110699           
  Branches           ?     7553           
==========================================
  Hits               ?    68567           
  Misses             ?    39570           
  Partials           ?     2562           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 02 '25 06:06 codecov[bot]

@miettal Hi, thanks for your contribution. Could you write down, what motivated you to do this change, and what use cases this will suit,

In my opinion, this would make most sense, to show this only for owners

lukasrgr avatar Jun 03 '25 07:06 lukasrgr

@lukasrgr This is a usecase for user who manages a lot of edges, like administrator. Current implementation, user needs to go overview for switching to other edge. This PR provides siwitching interface from sidebar to go other edge directly.

miettal avatar Jun 11 '25 03:06 miettal

In my opinion, this would make most sense, to show this only for owners

I think so, I will revise.

miettal avatar Jun 11 '25 05:06 miettal

@miettal i think we should make this optional, if it works for your use case,

@sfeilmeier what do you think, is this something that should be merged and shown to everyone?

lukasrgr avatar Jun 29 '25 19:06 lukasrgr

both is ok, I will follow.

if optionalization is needed, I wii add this commit. https://github.com/girasolenergy/openems-fork/commit/dfed40f287ecb1d8f69b1046c0f7c167092fb37f

miettal avatar Jun 30 '25 08:06 miettal

// I added optionalization change to this PR.

miettal avatar Jul 04 '25 00:07 miettal

rebased

miettal avatar Aug 04 '25 04:08 miettal

This PR has been automatically marked as stale due to inactivity

If it is still relevant, please update the PR. Otherwise, it will be automatically closed in 14 days.

Before updating, please review our Contribution Guidelines to ensure all required information is provided.

github-actions[bot] avatar Nov 08 '25 02:11 github-actions[bot]

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.

github-actions[bot] avatar Nov 22 '25 02:11 github-actions[bot]