openems icon indicating copy to clipboard operation
openems copied to clipboard

fix: add initialization variables to fix typescript strict mode errors.

Open Jasonlee6789 opened this issue 1 year ago • 3 comments

npx tsc --strict:

Found 1522 errors in 194 files. ↓ Found 1505 errors in 196 files.

Jasonlee6789 avatar Sep 30 '24 22:09 Jasonlee6789

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2824      +/-   ##
=============================================
+ Coverage      56.65%   59.07%   +2.43%     
- Complexity      8914     8918       +4     
=============================================
  Files           2167     1905     -262     
  Lines          91939    85257    -6682     
  Branches        6833     5807    -1026     
=============================================
- Hits           52081    50360    -1721     
+ Misses         37983    33100    -4883     
+ Partials        1875     1797      -78     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 30 '24 22:09 codecov[bot]

@Jasonlee6789 thx for your contribution, im not sure, if this PR has some purpose

lukasrgr avatar Mar 11 '25 08:03 lukasrgr

@Jasonlee6789 thx for your contribution, im not sure, if this PR has some purpose

Thank you for your review. The purpose of this PR is to fix uninitialized variables in the UI code and explicitly add null type annotations to variables initialized as null, in order to fix TypeScript strict mode errors and prevent potential runtime errors. The result of this PR is that after running npx tsc --strict, the number of errors was reduced from 1522 to 1505, eliminating 17 errors.

Jasonlee6789 avatar Mar 12 '25 00:03 Jasonlee6789

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 18 '25 07:09 github-actions[bot]

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.

github-actions[bot] avatar Oct 09 '25 02:10 github-actions[bot]