Multi use addition to symmetric peak shaving - Q3/24 Hackathon

[Laksh26]

Group: Laksh + Sebastian

The concept of fixed and soft limitations were created in this controller

[Laksh26]

@sfeilmeier review

[sebastianasen]

@parapluplu Thank you for a first review 💪

[parapluplu]

@Laksh26 Could you please provide me access to the branch? Then I would continue to add the desired changes to this pull request

[Laksh26]

@parapluplu i am not much familiar with GitHub, but i think i was able to add you as a collaborator to the fork. Does that work?

[sebastianasen]

@Laksh26 Could you please provide me access to the branch? Then I would continue to add the desired changes to this pull request

You can us Checkout with Github Desktop

[parapluplu]

@Laksh26 nice, I have push access, that should be sufficient. Thank you! Next week I'll likely find some time to work on this.

@sebastianasen That's only helpful to checkout this project locally. It's not enough to contribute to this pull request, as I need push access to the branch of the fork project where the pull request comes from :)

[parapluplu]

I've reworked the controller a bit so it states more explicitly to support a parallel multi use scenario. I'm still not happy with the configuration (minSocLimit and socHysteresis are always present, even allowParallelMultiuse flag is disabled. This is a bit confusing - but right now I don't have a better idea either, except removing the allowParallelMultiuse flag and just control everything via the minSocLimit flag - which we disregarded already in the discussion, so I'll keep the config as is for now :) )

I'm currently also working on writing an automated integration test for this change to test it with a running system (currently with simulated grid, production and consumption meter and simulated battery - it should also support real hardware setups, which is a bit more complicated). I'm planning to publish this integration test environment soon once it's a bit mature and covers some (really basic) tests - but that's another chapter and I'll open a post in the community forum about that. But before merging this change, I would also like todo an integration test to ensure it's quite stable. Unit tests are running into limits here for me for this use case. Since this is an explicit multi use controller, it means it must allow other follow up controllers to run. Unit tests do not fully emulate channel overwrite behavior, power constraint setting behavior etc. The latter one is quite easily solvable with a DummyPower implementation that supports constraints.

[github-actions[bot]]

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

[github-actions[bot]]

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.