openems icon indicating copy to clipboard operation
openems copied to clipboard

Fix: Cycle time change from wait for trigger to actual time

Open parapluplu opened this issue 1 year ago • 1 comments

If the config was changed from AbstractWorker.ALWAYS_WAIT_FOR_TRIGGER_NEXT_RUN to a value >= 0 again the cycle thread remaind in a waiting state. The reason for that is that the thread was put in an await state as soon as AbstractWorker.ALWAYS_WAIT_FOR_TRIGGER_NEXT_RUN was configured. This change allows a change at releases the thread again.

Testing: Unit tests, and the simulator app starts up and starts executing cycles

Note: The cycle worker implementation is using a stopwatch that does not allow to inject a custom clock. To improve unit tests, I can provide a pull request that refactors the stopwatch implementation first, if this change is wanted.

This change fixes an error that surfaces when using the SimulatorApp. The cycle never actually starts to execute.

parapluplu avatar Sep 11 '24 14:09 parapluplu

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:exclamation: There is a different number of reports uploaded between BASE (d0ae040) and HEAD (e9902b1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d0ae040) HEAD (e9902b1)
java 1 0
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #2790       +/-   ##
==============================================
- Coverage      56.65%   25.85%   -30.80%     
==============================================
  Files           2167      262     -1905     
  Lines          91939     6682    -85257     
  Branches        6833     1026     -5807     
==============================================
- Hits           52081     1727    -50354     
+ Misses         37983     4876    -33107     
+ Partials        1875       79     -1796     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 11 '24 15:09 codecov[bot]