OpenEMS
DRAFT - Implementation DEYE SUN-12K-SG04LP3-EU
@Rayleigh3105 this is 100% not finished, maybe consider marking this PR as draft as I and the others know based on the "Copy-Paste" it is not finished yet - will add some comments beforehand :)
See for e.g.:
https://openems.github.io/openems.io/openems/latest/contribute/coding-guidelines.html
Your complete Checkstyle is missing, there are no tests, and so on and so forth
@Rayleigh3105 you completely reverted my changes again..
I am sorry but as @sfeilmeier also told me please consider looking into the getting started and also learn some things about github before creating a PR please.. also use the getting started please !
@Rayleigh3105 reformatted it again, removed unused Classes again, please do not revert as it is not needed :)
@Sn0w3y Ahh sorry never wanted to create a PR this early. I just played around in gitHub. I´m trying to sort out the code in the next days 😆
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
To maintain transparency, I believe it would be more efficient for @sfeilmeier if you could address the issues in this pull request before resubmitting it. Like you, I am diligently working on my pull requests and acknowledge that I am not without fault. Based on my observations, @sfeilmeier is undoubtedly busy and appreciates contributions. However, he also faces the challenge of reviewing a significant amount of code that may be redundant, unnecessary, or incorrect in some pull requests, including some of my own.
Yeah never meant to open the PR in this stage, did forgot to make it a draft. Thanks for your participation.
@Sn0w3y Deplyoed it to the raspi. Code still working 👍 Now running on commit 3082fed32ed71e745406abad9cb25dd798737cdf
@Sn0w3y Deplyoed it to the raspi. Code still working 👍 Now running on commit 3082fed
Hi @Sn0w3y, unfurtunally it did not work as expected. Thee ESS broke with this change of the code. I reseted the branch and tested every commit. Now its working again.