openems icon indicating copy to clipboard operation
openems copied to clipboard

feature: implement the Entes MPR-15S-22 meter as modbus device

Open samuelBloch opened this issue 1 year ago • 5 comments

This pull request implements the Entes MPR-15S-22 network analyzer. The meter communicates over a serial modbus connection.

samuelBloch avatar Feb 14 '24 08:02 samuelBloch

Code Coverage

github-actions[bot] avatar Feb 14 '24 08:02 github-actions[bot]

Just a little thought from me - would't it be better to name it as follows:

io.openems.edge.meter.entes

and underneath the meters as packages to keep up if a new "Entes" meter is implemented? see here aswell:

https://community.openems.io/t/neues-meter-sdm-120/2385/7?u=sn0w3y

Sn0w3y avatar Feb 14 '24 19:02 Sn0w3y

Thanks for the input, I renamed the bundle. Could you please check if this is what you meant?

samuelBloch avatar Feb 15 '24 08:02 samuelBloch

Code Coverage

github-actions[bot] avatar Feb 15 '24 08:02 github-actions[bot]

Thanks for the input, I renamed the bundle. Could you please check if this is what you meant?

Yes, i do not know if it makes sense but i guess it should make sense :D

@sfeilmeier what do you think?

Sn0w3y avatar Feb 15 '24 18:02 Sn0w3y