openems icon indicating copy to clipboard operation
openems copied to clipboard

UI: AppCenter: RedeemKey -> Update of the SelectField

Open DerStoecki opened this issue 1 year ago • 5 comments

Issue

In the AppCenter -> redeemKey option On selecting a different key -> the key doesn't get visually updated. This is a bit irritating for the user.

RedeemKey

Fix

formly-select-field.extended -> Apply ChangeDetectorRef -> detectChanges() after setValue()

Note:

I am not sure if ChangeDetectorRef in this context is the best solution. But it worked.

DerStoecki avatar Feb 08 '24 11:02 DerStoecki

Code Coverage

github-actions[bot] avatar Feb 08 '24 11:02 github-actions[bot]

@michaelgrill i sae nothing breaking in here, do you agree?

lukasrgr avatar Feb 26 '24 00:02 lukasrgr

I m a little bit irritated what exactly is not working. Is it when someone has multiple keys registered and chooses a different one and then the select box wont get update? In my case this was working fine.

Btw it should not be important but i tested it with Chrome Browser.

michaelgrill avatar Feb 26 '24 08:02 michaelgrill

I m a little bit irritated what exactly is not working. Is it when someone has multiple keys registered and chooses a different one and then the select box wont get update? In my case this was working fine.

Btw it should not be important but i tested it with Chrome Browser.

yes thats the issue, someone has multiple registered keys and chooses a different one. but it is odd indeed. Especially bc a colleague of mine, who found the issue, uses chrome too. I am using Firefox however.

Edit: I will synch OpenEMS with our fork again an have a look into it.

DerStoecki avatar Feb 26 '24 09:02 DerStoecki

Converting to Draft, until I synched and tested again

DerStoecki avatar Feb 26 '24 09:02 DerStoecki

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 19 '25 13:09 github-actions[bot]

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.

github-actions[bot] avatar Oct 12 '25 02:10 github-actions[bot]