openems icon indicating copy to clipboard operation
openems copied to clipboard

Add Ireland and UK as options in OpenEMS

Open thomasjbhayes opened this issue 1 year ago • 2 comments

Ireland and UK were not options as countries in OpenEMS.

This commit adds them within the UI enums, i8n, and the SafetyCountry enum in OpenEMS edge.core.

thomasjbhayes avatar Jan 30 '24 15:01 thomasjbhayes

@thomasjbhayes: What is the use-case to add the countries?

Problem is, that e.g. io.openems.edge.core/src/io/openems/edge/app/enums/SafetyCountry.java is used in FENECON Home Apps currently - but they are not officially allowed in Ireland and UK.

In UI the change is not critical, but for certain OpenEMS distributions (like FEMS) it might be feasible to restrict the selectable countries.

sfeilmeier avatar Mar 31 '24 21:03 sfeilmeier

Hi Stefan,

Please excuse my delay in getting back to you.

The use case is that we plan to distribute our ESS using OpenEMS in Ireland and the UK and found that the countries were not selectable in the UI. Do the proposed changes cause any issue for Fenecon?

Thomas

thomasjbhayes avatar Apr 16 '24 17:04 thomasjbhayes

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 19 '25 18:09 github-actions[bot]

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.

github-actions[bot] avatar Oct 12 '25 02:10 github-actions[bot]