openems icon indicating copy to clipboard operation
openems copied to clipboard

Allow unauthenticated access to /live on Backend2Backend REST API

Open phfeustel opened this issue 2 years ago • 2 comments

Motivation When running the OpenEMS backend in (docker) containers and/or connect them via (cloud) load balancers, it is handy to have an easy to call liveness probe which does not need any authentication.

Side note: As the Backend2BackendRest service is also reliant on an up-and-running Metadataservice, I guess this check could even serve as a readiness probe, even though the Metadata isn't used actually.

phfeustel avatar Nov 21 '23 16:11 phfeustel

Hi Phil and Chris, While I am honoured that I have been chosen as a reviewer for this PR, I have to say that I work predominantly on the OpenEMS edge, and not on the backend. All I can say is that

  1. "Allow unauthenticated access" seems a bit dangerous to me
  2. Two dependencies are added to pom.xml. I am always very careful with changing this file. I can't judge whether the impact of this PR justifies that, but I would be very careful with that.

tsicking avatar Nov 24 '23 16:11 tsicking

@michaelgrill What's your opinion on this?

sfeilmeier avatar Nov 28 '23 23:11 sfeilmeier

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 19 '25 18:09 github-actions[bot]

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.

github-actions[bot] avatar Oct 13 '25 02:10 github-actions[bot]