docs icon indicating copy to clipboard operation
docs copied to clipboard

translation cleanup

Open danbjoseph opened this issue 3 years ago • 5 comments

storing all the translation files in the repo doesn't seem to be adding much value, and ends up with LOTS of changed files every time there's a change and we want to update all the languages. this PR takes those files out of the repo, and pulls the language strings down from Transifex during the build process. currently, in order to push changes that have occurred up to Transifex for translation, we still need to run:

make updatepot
make updatelangpo
make pushlang

but that could be changed to occur during the build process as well.

danbjoseph avatar Jul 05 '22 18:07 danbjoseph

Thanks @danbjoseph :+1: I think this might have some issues with the build command make pulllang, for example on a brand new environment I get:

make pulllang
tx pull --language "sw,ar,es,fr,te,fil,id"

Did you know that you can create an apitoken under your transifex user's settings?
(Read more at https://docs.transifex.com/api/introduction#authentication)
So, do you have an api token? [y/N]:

So the automated build would hang here.

pierotofy avatar Jul 06 '22 22:07 pierotofy

ah, you're right, i completely forgot about that piece. i'll look into if it's possible to get around that securely.

danbjoseph avatar Jul 07 '22 12:07 danbjoseph

@danbjoseph -- any solution for doing this securely?

smathermather avatar Aug 01 '24 14:08 smathermather

should be possible with https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions i can try and take a look soon

danbjoseph avatar Aug 01 '24 18:08 danbjoseph

Makes sense. Thanks!

smathermather avatar Aug 09 '24 02:08 smathermather