ODM icon indicating copy to clipboard operation
ODM copied to clipboard

Feat: track decimation

Open pierotofy opened this issue 2 years ago • 6 comments

This PR brings the changes suggested from https://github.com/mapillary/OpenSfM/pull/641 into ODM.

On small datasets this seems to decrease relative accuracy, so perhaps this might need to be adjusted to only be used on larger datasets (how large?)

Please help test, in particular:

  • How does relative/absolute accuracy change relative to the current baseline?
  • How do the final outputs look relative to the current baseline?
  • What are the runtime differences for the OpenSfM stage?

pierotofy avatar Nov 19 '23 16:11 pierotofy

What sizes do you want / need tested?

smathermather avatar Nov 20 '23 23:11 smathermather

A variety would be best (small, medium, large), but the main concern is just trying to answer the bullet points I mentioned above.

pierotofy avatar Nov 21 '23 02:11 pierotofy

Cool. I've got it running on a 1900 dataset. Seems like a decent size (larger than most test datasets) without taking overly long to run (should be done tomorrow afternoon). All defaults, one running on current and one on a fresh build of this branch.

smathermather avatar Nov 21 '23 05:11 smathermather

So far, I don't think I see any computational time differences in OpenSfM: image

smathermather avatar Nov 21 '23 15:11 smathermather

Only difference I see so far is progress bar differences for the same stage: image

smathermather avatar Nov 21 '23 18:11 smathermather

Definitely got some weird errors in the northeastern corner:

Kakuma_17A_Flight_02-report.pdf Kakuma_17A_Flight_02-trackdec-report.pdf

image

trackdec left, current right

image

smathermather avatar Nov 22 '23 00:11 smathermather