ODM icon indicating copy to clipboard operation
ODM copied to clipboard

Add PDF reports while using split-merge

Open pierotofy opened this issue 5 years ago • 9 comments

Currently ODM does not generate PDF reports when using split-merge. It could be possible to generate them by:

  • Recomputing/aggregating stats from submodels
  • Write a new report generation code (separate from OpenSfM's)

pierotofy avatar Jan 15 '21 15:01 pierotofy

I'd lean toward aggregate stats. Any reason to not have submodel stats as well? For larger datasets it could be more useful than global stats.

smathermather avatar Jan 15 '21 15:01 smathermather

I agree to both. The bottom line is that the split-merge report would contain slightly different information compared to normal runs.

pierotofy avatar Jan 15 '21 15:01 pierotofy

Yup. Agreed.

smathermather avatar Jan 15 '21 19:01 smathermather

@pierotofy opensfm/action/compute_statistics.py calls stats.py functions that works on a list of reconstructions.

YanNoun avatar Jan 18 '21 10:01 YanNoun

Didn't know that. Thanks @YanNoun ! I'll try it out.

pierotofy avatar Jan 18 '21 13:01 pierotofy

The save_heatmap/save_topview might be super slow with 100K/1M points, feel free to run some random index-based decimation.

YanNoun avatar Jan 18 '21 13:01 YanNoun

I did notice some slowdowns with larger datasets; would this be a good idea for a PR to OpenSfM for the compute_statistics command? (I could add a --decimate flag)

pierotofy avatar Jan 18 '21 14:01 pierotofy

Yup definitely, that would be great !

YanNoun avatar Jan 18 '21 14:01 YanNoun

https://github.com/mapillary/OpenSfM/pull/695

I opted to allow a user to set a cap on the number of points using random sampling. Definitely helps keep runtime in check!

pierotofy avatar Jan 18 '21 19:01 pierotofy