ClusterODM icon indicating copy to clipboard operation
ClusterODM copied to clipboard

migrate code base to type script

Open zeevdr opened this issue 1 year ago • 3 comments

I've added the ability yo write nodeodm code in typescript. still need to update documentation

zeevdr avatar Mar 08 '23 13:03 zeevdr

@pierotofy Any comments on this PR?

tariqislam avatar Apr 23 '23 16:04 tariqislam

@zeevdr -- I haven't tested yet, but can you fix the branch merge conflicts for libs/asr-providers/aws.js and libs/proxy.js?

Also, it looks like there's a lot of boiler plate still in tsconfig.json. If this is normal, by all means leave it. I don't know conventions here, and often with configs, we leave the possible options in the comments. If it typical to clean this up, feel free to reduce that to only what is needed. But as I say: I don't know typescript conventions, so whichever fits with the larger ecosystem conventions.

smathermather avatar May 15 '23 00:05 smathermather

What the goal is:

  • A migration to TypeScript (for the obvious benefits of static typing and tooling)

What we currently have in this PR:

  • A skeleton for the beginning of the goal above (no actual code has been migrated to take advantage of TypeScript's features)

Simply enabling TypeScript support will just remove compatibility with vanilla JS (a net negative). Happy to leave this in a typescript branch, but as-is this cannot be merged into master (even after resolving conflicts).

pierotofy avatar May 19 '23 17:05 pierotofy