OpenDrift
Fix parquet io
Looks like the parquet exporter wasn't updated when output changes happened with OpenDrift. This is my attempt to fix it. As a disclaimer, I wrote these changes using ChatGPT because I was not familiar enough with parquet nor the details of the original code to get it right. I tested it with OpenDrift's tests and my own subsidiary package tests and it looks like it is working but I encourage an extra eye on this if possible.
Hi,
Apart from the small concerns regarding the updates to basemodel (see comments above), this seems fine to me.
However, I have never used the parquet writer, so perhaps @poplarShift or @mateuszmatu would be interested to have a look before merging this? If no comments until tomorrow, I guess we can just merge it, and they can have a look later. The writer is anyway not functional at the moment.
I have not looked more into this, as I also prefer netCDF. Maybe @poplarShift can update this?
@knutfrode Thanks for your comments. I can integrate them later today or Monday in case we hear from @poplarShift first.
Hi all, sorry for the silence on this. I've been a bit hesitant on whether this I/O module should simply be discontinued (even though I'd quite like the functionality) and just serve as inspiration/for future reference.
Apart from the maintenance thing there's also the mysterious issue #1321 which I still haven't figured out. Maybe for now the most pragmatic thing is to take it out again?
But then I guess that if Kristen can make it work again, then we could keep it, and it will still serve as inspiration for others for future development (or generalisation).