OpenDream icon indicating copy to clipboard operation
OpenDream copied to clipboard

Published 20 hours ago • verified publisher icon OpenDreamProject

Comparison Operators Don't Support Constant Folding

Open ike709 opened this issue 1 year ago • 6 comments

  • [ ] >=
  • [ ] <=
  • [ ] <
  • [ ] >
  • [ ] ~=
  • [x] == (Done in https://github.com/wixoaGit/OpenDream/pull/834)
  • [x] != (Done in https://github.com/wixoaGit/OpenDream/pull/834)

See Binary.cs and Constant.cs

ike709 avatar Oct 01 '22 20:10 ike709

Duplicate of #828

wixoaGit avatar Oct 02 '22 02:10 wixoaGit

This one has a checklist

ike709 avatar Oct 02 '22 03:10 ike709

This one also needs ~= added to the checklist

ZeWaka avatar Oct 10 '22 03:10 ZeWaka

not anymore

ike709 avatar Oct 10 '22 05:10 ike709

What about <>? I thought I remember someone mentioning that recently, but I'm not sure where.

Hinaichigo avatar Oct 10 '22 05:10 Hinaichigo

What about <>? I thought I remember someone mentioning that recently, but I'm not sure where.

<> is just an alias for != so that should be done in the parser

Edit: It's already done image

ZeWaka avatar Oct 10 '22 19:10 ZeWaka