OpenDream icon indicating copy to clipboard operation
OpenDream copied to clipboard

Nuke DMASTFolder

Open ike709 opened this issue 3 months ago • 3 comments

Nukes DMASTFolder. It's deprecated and removing it shaves a consistent 6 seconds off my third-run TG compile time (45s -> 39s).

This uncovered an OD bug in the following preprocessed TG code:

/proc/collect_vv(obj/item/item)
    var/static/list/ignored_vars = list(
        (@#animate_movement# ||item.animate_movement),
        (@#datum_flags# ||item.datum_flags),
        (@#fingerprintslast# ||item.fingerprintslast),
        (@#layer# ||item.layer),
        (@#plane# ||item.plane),
        (@#screen_loc# ||item.screen_loc),
        (@#tip_timer# ||item.tip_timer),
        (@#vars# ||item.vars),
        (@#x# ||item.x),
        (@#y# ||item.y),
        (@#z# ||item.z),
    )

DMASTFolder was returning just the LHS as a constant string, which hid the fact that OD couldn't resolve the deref in the RHS. I think I got it working, but BuildIdentifier() is such a mess I'm not 100% sure this is the proper fix.

ike709 avatar Sep 08 '25 09:09 ike709