OpenDream icon indicating copy to clipboard operation
OpenDream copied to clipboard
verified publisher icon OpenDreamProject

`AssignAndPushReferenceValue` peephole opt

Open ike709 opened this issue 1 year ago • 2 comments

When AssignNoPush is followed by PushReferenceValue and they both have the same reference, they're reduced to a single Assign with a new AssignAndPushReferenceValue optimization. This saves about ~17,000 redundant ReadReference() and GetReferenceValue() calls in TG bytecode.

ike709 avatar Oct 19 '24 23:10 ike709

title and desc incorrect

ZeWaka avatar Oct 20 '24 07:10 ZeWaka

waka lacking reading comprehension moment

ike709 avatar Oct 20 '24 19:10 ike709

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 03 '24 01:11 github-actions[bot]

When are we getting AssignAndAppendAndPushReferenceValueNTimesThenReturnNFloatListsThenPop tho

ZeWaka avatar Nov 06 '24 00:11 ZeWaka