OpenDream icon indicating copy to clipboard operation
OpenDream copied to clipboard

Implement replacetextEx_char, reimplement Splittext to match new 515 behavior

Open MyNameIsRomayne opened this issue 1 year ago • 3 comments

Very simple one-liner piggybacking off jointext and spltitext, with an update to Splittext so that it functions properly.

Basically, splittext has been updated in 515 to include the start and end of the string, so the current implementation of Splittext now remembers that and pre/appends those parts to the first/last elements.

The splittext unit tests were updated based off the output from DM for 515: image

Originally this was just going to be a one-liner for replacetextEx_char, but after being informed of the changes needed to Splittext I decided to go ahead and do that too, so that this works.

MyNameIsRomayne avatar Aug 13 '24 21:08 MyNameIsRomayne

Drafting due to a new test I added failing, going to resolve that (Empty strings should be splitting on every char, but instead dont split at all)

MyNameIsRomayne avatar Aug 13 '24 21:08 MyNameIsRomayne

image Reopening because I am genuinely unable to fix this without worsening the code quality beyond the review-necessary state it is in. Please advise on this

MyNameIsRomayne avatar Aug 14 '24 21:08 MyNameIsRomayne

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 09 '24 18:09 github-actions[bot]

Maybe mark as draft if it's not ready for merge

amylizzle avatar Dec 05 '24 15:12 amylizzle

Yeah these haven't been worked on for a while, I'm not sure if I'll be able to get to them

MyNameIsRomayne avatar Dec 05 '24 15:12 MyNameIsRomayne

Not working on this anymore, unfortunately. I don't feel confident I could make genuine contributions to the project without significantly taking up other's time

MyNameIsRomayne avatar Jul 04 '25 19:07 MyNameIsRomayne