OpenDream icon indicating copy to clipboard operation
OpenDream copied to clipboard

Implement `as` syntax for multiple base types (`mob|obj|turf`)

Open MyNameIsRomayne opened this issue 1 year ago • 2 comments

This is an attempt to support code like

for (var/atom/A as mob|obj|turf|area in view(null, null))

to continue the implementation parity between OD and DM

MyNameIsRomayne avatar Aug 12 '24 01:08 MyNameIsRomayne

This is probably not a great first project (it was supposedly easy at first, but the proper implementation is slightly more complicated) for me, so the code quality is dubious.

Current issues are something along the lines of Error OD0000 at code/mob/living/silicon/ai.dm:1102:11: Negative stack size though this should all work fine once these errors are resolved (?)

MyNameIsRomayne avatar Aug 12 '24 01:08 MyNameIsRomayne

It compiles without errors so I'm undrafting this and re-requesting review

MyNameIsRomayne avatar Aug 12 '24 13:08 MyNameIsRomayne

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 15 '24 23:11 github-actions[bot]

Abandoned?

amylizzle avatar Dec 05 '24 15:12 amylizzle

Yeah these haven't been worked on for a while, I'm not sure if I'll be able to get to them. Someone else can continue it or work on it if they want

MyNameIsRomayne avatar Dec 05 '24 15:12 MyNameIsRomayne

Closing in favor of #2228

wixoaGit avatar Feb 24 '25 01:02 wixoaGit