HellSpawner icon indicating copy to clipboard operation
HellSpawner copied to clipboard

Issue 306 (Merge DCC and DC6)

Open GibranHL0 opened this issue 4 years ago • 5 comments

PR Created

⚠️ The PR goal is to solve issue #306

This PR is a work in progress, its creation is to show the current development of the issue. I'll make changes.

Things to be done

  • [x] Create Widget, DCC and DC6 structures
  • [x] Create WidgetState, DCCState and DC6State structures
  • [x] Write documentation
  • [x] Create Widget interfaces
  • [ ] Rewrite encode
  • [ ] Rewrite decode
  • [x] Rewrite initState
  • [x] Rewrite setState
  • [x] Rewrite runPlayer
  • [x] Rewrite recalculateTiledViewWidth
  • [x] Rewrite recalculateTiledViewHeight
  • [x] Rewrite createImage

GibranHL0 avatar Jul 13 '21 00:07 GibranHL0

I don't think that rewriting the encode/decode for the dcc and dc6 format should be part of this PR. those are two very large changes, each deserving their own PR.

gravestench avatar Jul 19 '21 17:07 gravestench

Sure then, I'll revert those changes

GibranHL0 avatar Jul 29 '21 23:07 GibranHL0

What's the status on this?

gravestench avatar Aug 04 '21 18:08 gravestench

I'm doing great, I'm working with a single property in an embedded structure that the linter detected as not used even if it was, so I'm finding a new way to re-write the structure.

GibranHL0 avatar Aug 05 '21 20:08 GibranHL0

I'm working with a single property in an embedded structure that the linter detected as not used even if it was,

btw, it is a known bug with unexported struct fields. you can just nolint it: https://golangci-lint.run/usage/false-positives/#nolint

gucio321 avatar Aug 09 '21 16:08 gucio321