the_od_bods icon indicating copy to clipboard operation
the_od_bods copied to clipboard

Add tests for PRs

Open KarenJewell opened this issue 3 years ago • 2 comments

Integration tests?

Or otherwise e.g. if adding new scraper, check:

  • Script is already called in Github Actions
  • Output is already handled in mergedata.py
  • Additional package dependencies needed for GH Actions

KarenJewell avatar Jul 23 '22 12:07 KarenJewell

Just to add to this, I think it would be a good idea to add a pre-flight check flag to the pipeline to allow it to run but then not commit the results to GitHub.

This would let us test any changes we make when adding new scripts/features during dev work on the pipeline. We could also use it to do a test run of the script on a Friday morning to make sure it runs without crashing before the current live run that happens at mid-day.

JackGilmore avatar Jul 29 '22 10:07 JackGilmore

I'll look at adding python tests (pytest), as part of the refactoring. #122 I'll probably do that first based on how much refactoring there needs done 😆

gavbarnett avatar Aug 06 '22 18:08 gavbarnett