odp icon indicating copy to clipboard operation
odp copied to clipboard

Missing ethernet padding remove while reassemble small fragment

Open chrhong opened this issue 2 years ago • 0 comments

Hi,

Does those reassemble example code forget to remove ethernet padding ? https://github.com/OpenDataPlane/odp/blob/9a6fda2d55a02dd3e64371b77de04f512453a341/example/ipfragreass/odp_ipfragreass_reassemble.c#L482

The padding is filled while ethernet frame too small which < 64bytes. Then zero padding is extended. Those padding should be removed manually while reassemble those fragments.

You can refer dpdk example: https://github.com/DPDK/dpdk/blob/4a6672c2d301c105189ae74de73260af204c5ee8/lib/ip_frag/rte_ipv4_reassembly.c#L140

Br, Christian

chrhong avatar Sep 20 '22 09:09 chrhong