App crashes when clicking "Optimize Geometry" without any atom

[perminder-17]

Signed-off-by: Perminder Singh [email protected] issue : #1660

Developer Certificate of Origin Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

[welcome[bot]]

Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests.

[perminder-17]

Here's the screenshot of the dialogue box when we click on optimize geometry without any atom.

Thanks:)

[vinayakjeet]

Hello @ghutchis @perminder-17 , to correct the DCO error, I suggest using the command git commit -s -m followed by your commit message. This should resolve the issue, allowing you to create a correct PR. Thank you.

[ghutchis]

The instructions can be found on the "Details" link: https://github.com/OpenChemistry/avogadrolibs/pull/1661/checks?check_run_id=23535819030

[perminder-17]

The instructions can be found on the "Details" link: https://github.com/OpenChemistry/avogadrolibs/pull/1661/checks?check_run_id=23535819030

Thanks, I guess the DCO check passes now.

[github-actions[bot]]

Here are the build results Avogadro2.AppImage macOS.dmg Win64.exe Artifacts will only be retained for 90 days.

[welcome[bot]]

Congrats on merging your first pull request! 🎉 Thanks for making Avogadro better for everyone!

[github-actions[bot]]

Here are the build results Avogadro2.AppImage Win64.exe Artifacts will only be retained for 90 days.