liblightnvm
liblightnvm copied to clipboard
Simple fix for #33
This is a very primitive fix for #33, which can serve as inspiration for the real fix. It will skip any addresses that is out of bounds.
Hi Niclas,
I will pick this up in a couple of days unless I hear otherwise from Simon.
Thank you! Matias
I will take a look over the weekend.
Hi Niclas,
I completely agree that the alignment to stripe unit, and minimal size in stripe units should not be a restriction on reads. This looks good for the case of nsectr == 1
, so thanks for this!
However, I have a concern for nsectr
greater than 1 when un-aligned with the stripe-size, since all calculations are based on the stripe-size and stripe-unit assumptions which are removed. So, before pulling this change in, I would like to expand the vblk-testcases to verify behaviour for unaligned reads.
I look at doing so over the coming week.
Cheers, Simon
Thank you very much. Let me know if you need more from me.
Hi @niclashedam, I didn't get the cycles I needed last week to update the tests, however, should be doable this week. Cheers, Simon
Hi @safl, it has been a while. I'll like to pull it in. Can you let me know if you want to continue to maintain this project? Else I will take on the responsibility.
Hi @MatiasBjorling, it sure has. I will continue maintaining this project and allocate more cycles to it.
Rebased this as well.
Any news on this? 🤓