liblightnvm icon indicating copy to clipboard operation
liblightnvm copied to clipboard

Simple fix for #33

Open niclashedam opened this issue 4 years ago • 9 comments

This is a very primitive fix for #33, which can serve as inspiration for the real fix. It will skip any addresses that is out of bounds.

niclashedam avatar Oct 21 '19 09:10 niclashedam

Hi Niclas,

I will pick this up in a couple of days unless I hear otherwise from Simon.

Thank you! Matias

MatiasBjorling avatar Oct 25 '19 08:10 MatiasBjorling

I will take a look over the weekend.

safl avatar Oct 25 '19 08:10 safl

Hi Niclas,

I completely agree that the alignment to stripe unit, and minimal size in stripe units should not be a restriction on reads. This looks good for the case of nsectr == 1, so thanks for this!

However, I have a concern for nsectr greater than 1 when un-aligned with the stripe-size, since all calculations are based on the stripe-size and stripe-unit assumptions which are removed. So, before pulling this change in, I would like to expand the vblk-testcases to verify behaviour for unaligned reads. I look at doing so over the coming week.

Cheers, Simon

safl avatar Oct 27 '19 18:10 safl

Thank you very much. Let me know if you need more from me.

niclashedam avatar Oct 27 '19 18:10 niclashedam

Hi @niclashedam, I didn't get the cycles I needed last week to update the tests, however, should be doable this week. Cheers, Simon

safl avatar Nov 04 '19 07:11 safl

Hi @safl, it has been a while. I'll like to pull it in. Can you let me know if you want to continue to maintain this project? Else I will take on the responsibility.

MatiasBjorling avatar Dec 06 '19 13:12 MatiasBjorling

Hi @MatiasBjorling, it sure has. I will continue maintaining this project and allocate more cycles to it.

safl avatar Dec 06 '19 13:12 safl

Rebased this as well.

niclashedam avatar Dec 11 '19 09:12 niclashedam

Any news on this? 🤓

niclashedam avatar Apr 29 '21 08:04 niclashedam