opencti icon indicating copy to clipboard operation
opencti copied to clipboard

Upgrade passport saml to 5.x

Open aHenryJard opened this issue 1 year ago • 4 comments

Description

Despite green CI upgrade to 0.9.2 is breaking at least SAML authentication. Some code changes are required for upgrade.

see https://github.com/OpenCTI-Platform/opencti/commit/b35c33ca035d17ab812783d06e02470c953002fe

Error message is

"errorHandler object is no longer supported, switch to onError!"

Passport saml is related see https://github.com/OpenCTI-Platform/opencti/pull/8064

Environment

  1. OS (where OpenCTI server runs): { e.g. Mac OS 10, Windows 10, Ubuntu 16.4, etc. }
  2. OpenCTI version: { e.g. OpenCTI 1.0.2 }
  3. OpenCTI client: { e.g. frontend or python }
  4. Other environment details:

SAML Authentication at least.

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. { e.g. Run ... }
  2. { e.g. Click ... }
  3. { e.g. Error ... }

Expected Output

Actual Output

Additional information

Screenshots (optional)

aHenryJard avatar Sep 17 '24 08:09 aHenryJard

@aHenryJard This one can help I think: https://github.com/OpenCTI-Platform/opencti/pull/8064.

SamuelHassine avatar Sep 17 '24 09:09 SamuelHassine

@aHenryJard This one can help I think: #8064.

Yes I think that we need to do both at the same time.

aHenryJard avatar Sep 17 '24 12:09 aHenryJard

update: actually updating passport-saml to 5.0.0 is not enough, @nodesaml/nodesaml 5.0.0 is still not compatible with @xmldom/xmldom 0.9.+. Need to stick on 0.8.10 for now.

aHenryJard avatar Oct 14 '24 13:10 aHenryJard

Merged on 6.4 release branch for passport-saml 5, xmldom still must be done be can't in current version of passport-saml

aHenryJard avatar Oct 16 '24 08:10 aHenryJard

@aHenryJard So can we close the ticket?

nino-filigran avatar Oct 23 '24 10:10 nino-filigran

@nino-filigran it's on 6.4 release branch

aHenryJard avatar Oct 28 '24 08:10 aHenryJard