opencti icon indicating copy to clipboard operation
opencti copied to clipboard

Popover Removal - Locations

Open daimyo007 opened this issue 1 year ago • 1 comments

Proposed changes

  • Remove the ... popover icon.
  • Move the "Delete" from this popover into the Drawer for the item, have the button be on the bottom left of the drawer in red
  • Float the Enrich option to the top row and use the default cloud enrichment icon
  • Only applies to cases

This work is complemenatry to the FAB replacement PRs that have been being submiited.

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [x] Where necessary I refactored code to improve the overall quality

Further comments

This is a multiple part PR related to the FAB button work. This PR updates the popovers for the Location section. There is a related PR for Analyses section: https://github.com/OpenCTI-Platform/opencti/pull/8106. There is a related PR for Cases section: https://github.com/OpenCTI-Platform/opencti/pull/8121

daimyo007 avatar Aug 29 '24 06:08 daimyo007

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.30%. Comparing base (c7a29d4) to head (857b170). Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8199   +/-   ##
=======================================
  Coverage   66.29%   66.30%           
=======================================
  Files         597      597           
  Lines       60949    60949           
  Branches     6258     6260    +2     
=======================================
+ Hits        40407    40412    +5     
+ Misses      20542    20537    -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 29 '24 14:08 codecov[bot]