opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[backend] Improve redis sessions list perf (#7943)

Open SouadHadjiat opened this issue 1 year ago • 1 comments

Proposed changes

  • prevent locking the event loop when parsing users sessions

Related issues

  • #7943

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [ ] Where necessary I refactored code to improve the overall quality

SouadHadjiat avatar Aug 20 '24 16:08 SouadHadjiat

Codecov Report

Attention: Patch coverage is 62.25166% with 57 lines in your changes missing coverage. Please review.

Project coverage is 66.28%. Comparing base (bd767c4) to head (dfe2763). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cti-platform/opencti-graphql/src/database/redis.ts 51.76% 41 Missing :warning:
...i-platform/opencti-graphql/src/database/session.js 82.00% 9 Missing :warning:
...rm/opencti-graphql/src/manager/telemetryManager.ts 0.00% 4 Missing :warning:
...pencti-platform/opencti-graphql/src/domain/user.js 60.00% 2 Missing :warning:
...-platform/opencti-graphql/src/http/httpPlatform.js 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8119      +/-   ##
==========================================
- Coverage   66.30%   66.28%   -0.02%     
==========================================
  Files         597      597              
  Lines       61033    61092      +59     
  Branches     6275     6282       +7     
==========================================
+ Hits        40468    40497      +29     
- Misses      20565    20595      +30     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 16:08 codecov[bot]

is it still a PR to be worked on or should we close it @richard-julien ?

SouadHadjiat avatar Apr 14 '25 14:04 SouadHadjiat

I think you can close it.

richard-julien avatar Apr 14 '25 17:04 richard-julien