opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[frontend/backend] Create public dashboards from dashboard list pages (#6509)

Open lndrtrbn opened this issue 1 year ago • 2 comments

Proposed changes

  • Can create a new public dashboard from the page listing public dashboards
  • Can create a new public dashboard from an item of the list of custom dashboards

Related issues

  • #6509

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [x] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [x] Where necessary I refactored code to improve the overall quality

Further comments

To test use at least 2 different users. For each one create several dashboards and give different access to the other user. When creating a public dashboard, pay attention to dashboards you can create a public and the ones you can't.

You should be able to create a new public dashboard only if you have "can manage" access.

lndrtrbn avatar Aug 20 '24 07:08 lndrtrbn

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.04%. Comparing base (bd48a9b) to head (472ef32). Report is 5 commits behind head on master.

Files Patch % Lines
.../modules/publicDashboard/publicDashboard-domain.ts 21.42% 11 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8114      +/-   ##
==========================================
- Coverage   66.05%   66.04%   -0.02%     
==========================================
  Files         597      597              
  Lines       59689    59699      +10     
  Branches     6076     6078       +2     
==========================================
  Hits        39430    39430              
- Misses      20259    20269      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 08:08 codecov[bot]

I have an issue, when a user have one dashbord (a a public dashboard associated), and an other user without dashboards click on public dashboard

FIRST USER : (create a dashboard and share it) image

SECOND USER : (has no dashboard) error

frapuks avatar Aug 23 '24 09:08 frapuks