opencti icon indicating copy to clipboard operation
opencti copied to clipboard

Popover Removal - Analyses (Updated)

Open daimyo007 opened this issue 1 year ago • 2 comments

Proposed changes

  • Remove the ... popover icon.
  • Move the "Delete" from this popover into the Drawer for the item, have the button be on the bottom left of the drawer in red
  • Float the Enrich option to the top row and use the default cloud enrichment icon
  • Only applies to analyses

This work is complemenatry to the FAB replacement PRs that have been being submiited.

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [x] Where necessary I refactored code to improve the overall quality

Further comments

This is a multiple part PR related to the FAB button work. This PR updates the popovers for the Analysis section. There is a related PR for Cases section: https://github.com/OpenCTI-Platform/opencti/pull/8121

daimyo007 avatar Aug 19 '24 22:08 daimyo007

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.31%. Comparing base (438ccf5) to head (7e25b39). Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8106      +/-   ##
==========================================
+ Coverage   66.29%   66.31%   +0.01%     
==========================================
  Files         597      597              
  Lines       60958    60958              
  Branches     6263     6265       +2     
==========================================
+ Hits        40412    40422      +10     
+ Misses      20546    20536      -10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 23 '24 04:08 codecov[bot]

@daimyo007 - Tested with and without the Feature Flags manually. Pipeline is all passing now. Rebased to 6.2.15. Please swap to OPEN so Filigran can review.

ParamConstructor avatar Aug 23 '24 16:08 ParamConstructor

I don't know if it is related to your work but in Cases we can see Update button AND Popover {DD4789B6-24EC-442F-B2D3-F164C803B0F5}

marieflorescontact avatar Oct 22 '24 13:10 marieflorescontact

Cases is a seperate PR (https://github.com/OpenCTI-Platform/opencti/pull/8121) - but the Update button seems to have merged incorrectly into this branch onto Cases - let me have @daimyo007 fix this.

ParamConstructor avatar Oct 22 '24 13:10 ParamConstructor

ContainerHeader.jsx is used by other containers such as Cases. This could be the reason why we have Update button in Cases

marieflorescontact avatar Oct 22 '24 13:10 marieflorescontact

ContainerHeader.jsx is used by other containers such as Cases. This could be the reason why we have Update button in Cases

This is my finding as well. In the other two PRs we did not include the container code because then it would be duplicate code. Report has the container code that is necessary, and that is why we have it appearing as double for cases and locations. I believe that this PR should be the last one approved, but it will work as expected with the other two as seen when you look at Reports in this PR.

daimyo007 avatar Oct 22 '24 13:10 daimyo007