opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[frontend] Group members are inconsistent and can lead to mistakes on managing RBAC (#8050)

Open SarahBocognano opened this issue 1 year ago • 1 comments

Proposed changes

  • Change default pagination of group's member query from 20 (by default) to 500

Related issues

  • https://github.com/OpenCTI-Platform/opencti/issues/8050

SarahBocognano avatar Aug 19 '24 08:08 SarahBocognano

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.23%. Comparing base (a27b344) to head (849268c). Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8098   +/-   ##
=======================================
  Coverage   66.22%   66.23%           
=======================================
  Files         597      597           
  Lines       60433    60433           
  Branches     6202     6205    +3     
=======================================
+ Hits        40022    40025    +3     
+ Misses      20411    20408    -3     
Flag Coverage Δ
66.22% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 19 '24 08:08 codecov[bot]

What is the status of this PR @Kedae now that data tables have been merged?

SouadHadjiat avatar Sep 10 '24 16:09 SouadHadjiat

Not fixed by latest changes to DataTables. GroupEditionContainer now uses a DataTableWithoutFragment, which does not include pagination. passed 20 members selected, the list in the drawer does not work right.

labo-flg avatar Sep 17 '24 10:09 labo-flg

@SarahBocognano please check against latest master if the issue is still here. You can apply your quick fix if it solves the problem.

@labo-flg After checking with lastest master branch, the problem still occurs. The fix made by this PR is fixing it though

labo-flg avatar Sep 26 '24 18:09 labo-flg

Update: This PR is still valid because de data tables didn't resolved the pagination problem

SarahBocognano avatar Oct 01 '24 14:10 SarahBocognano