opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[frontend] Add Attack pattern list in Knowledge/Attack pattern with massive operations (#4230)

Open Gwendoline-FAVRE-FELIX opened this issue 1 year ago • 1 comments

Proposed changes

On Matrix View:

  • Add a new online view of the matrix with massive operations
  • Moving the matrix filter
  • Remove "Display only used techniques"

On Kill chain View anc Courses of actions View:

  • Add the matrix name before the category title
  • Remove “Display only used techniques” and “Enable invert colors” (hide it)

Related issues

  • https://github.com/OpenCTI-Platform/opencti/issues/4230

Gwendoline-FAVRE-FELIX avatar Aug 09 '24 07:08 Gwendoline-FAVRE-FELIX

Codecov Report

Attention: Patch coverage is 47.76119% with 35 lines in your changes missing coverage. Please review.

Project coverage is 66.23%. Comparing base (841503b) to head (d48bf58). Report is 1 commits behind head on release/6.4.0.

Files with missing lines Patch % Lines
...ti-platform/opencti-graphql/src/http/httpServer.js 0.00% 11 Missing :warning:
...i-platform/opencti-graphql/src/config/providers.js 0.00% 10 Missing :warning:
...latform/opencti-graphql/src/database/middleware.js 10.00% 9 Missing :warning:
...-platform/opencti-graphql/src/http/httpPlatform.js 0.00% 2 Missing :warning:
...opencti-graphql/src/manager/notificationManager.ts 71.42% 2 Missing :warning:
...ti-platform/opencti-graphql/src/graphql/graphql.js 0.00% 1 Missing :warning:
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #7996      +/-   ##
=================================================
+ Coverage          66.21%   66.23%   +0.02%     
=================================================
  Files                597      597              
  Lines              60430    60441      +11     
  Branches            6205     6205              
=================================================
+ Hits               40011    40031      +20     
+ Misses             20419    20410       -9     
Flag Coverage Δ
66.23% <47.76%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 26 '24 15:08 codecov[bot]

In an entity>Knowledge>AttackPattern>Matrix view : there is only one kill chain in the kill chain list, even if other kill chains exist : image

Archidoit avatar Sep 06 '24 07:09 Archidoit

When hovering the 'enable inverted colors' icon, the circle is not centered on the icon : image

Archidoit avatar Sep 06 '24 07:09 Archidoit

In the Matrix in-line view: add a filter on name with for instance : name don't start with XXX You have entities with name starting with XX ! (see screenshort) It's because it's not really the name that is displayed in the 'name' column, but the representative... Either display only the name in the 'name' column (like in the Attack pattern screen), or change the column name for 'representative'.

image

Archidoit avatar Sep 06 '24 07:09 Archidoit

But I've got all the Kill chains in the filter. Kill Chain Filter

Gwendoline-FAVRE-FELIX avatar Sep 06 '24 08:09 Gwendoline-FAVRE-FELIX

I've corrected the hover and the name column. As for the display in the kill chain filter, you need to relaunch your frontend for it to be up to date.

Gwendoline-FAVRE-FELIX avatar Sep 06 '24 14:09 Gwendoline-FAVRE-FELIX

In Matrix in line view :

  • Columns sorting not working
  • when clicking on a label chip in the list, the associated label filter is not added
  • the 'add filtering' option is not present for columns even if we can filter on them image

Archidoit avatar Sep 19 '24 16:09 Archidoit

The already added attack patterns are not checked in the 'create relationship' edition form list, even after reload : image

Maybe try to fix this in this PR?

Archidoit avatar Sep 19 '24 16:09 Archidoit

When you click on export to image or pdf from the matrix in line view : image

the screen is blocked here : image

Archidoit avatar Sep 19 '24 16:09 Archidoit

inconsistency with elsewhere in the platform: the filters are placed on the same line than the search bar image

(instead of just below) : image

Archidoit avatar Sep 19 '24 16:09 Archidoit

Exports don't take filters into account

  • Add a filter in the attack pattern matrix in line list image

  • Do an export

  • The whole list of attack pattern is exported (instead of only the attack patterns matching the filter) :

Archidoit avatar Sep 19 '24 16:09 Archidoit

Filters are repercuiting elsewhere:

  • Add a filter in the attack patterns matrix in line list image

  • Reload the page

  • The added filter is present in every 'create a relationship' lists image

Archidoit avatar Sep 19 '24 16:09 Archidoit

  • missing view buttons tooltip when we are in Matrix in line view image

  • need to reload to see added attack patterns in matrix in line view

Archidoit avatar Sep 26 '24 08:09 Archidoit

Two different typo for the tooltip 'matrix in line view' depending on which view we are : image

image

--> chose with or without '-' and do the appropriated translations

Archidoit avatar Sep 30 '24 15:09 Archidoit