opencti icon indicating copy to clipboard operation
opencti copied to clipboard

Proposed Color Changes to the Left Navigation Menu

Open dotdev8 opened this issue 1 year ago • 3 comments

Proposed changes

  • The left navigation top level and submenu items turn blue when user is on one of those submenu pages.

Related issues

  • No Issues

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [x] Where necessary I refactored code to improve the overall quality

Further comments

Tests for this PR were done in browser by observing the behavior when a submenu page is selected. Test cases are not relevant for this PR.

dotdev8 avatar Jul 18 '24 13:07 dotdev8

Hello @dotdev8,

Currently your code is not aligned with what we want the leftbar to look like. You have lost the "Dashboard" button in top of the left bar + we don't want the whole subMenu to be colored when selected, the "section" part can be usefull, but that's all.

For example there : image I would like Data to be colored, but not Entities, Relationships & co, and I'm missing the Home button

Kedae avatar Aug 02 '24 08:08 Kedae

Additionnaly, please do not commit files that have nothing to do with the matter. In your case the yarn upgrade shoud not be in your review

Kedae avatar Aug 02 '24 08:08 Kedae

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.74%. Comparing base (202d1de) to head (6e357bd). Report is 174 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7752      +/-   ##
==========================================
+ Coverage   67.72%   67.74%   +0.01%     
==========================================
  Files         572      574       +2     
  Lines       71041    71123      +82     
  Branches     6045     6057      +12     
==========================================
+ Hits        48115    48182      +67     
- Misses      22926    22941      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 06 '24 19:08 codecov[bot]