opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[backend] Test CSV bundler with Indicators with labels and kill chain phases

Open Goumies opened this issue 1 year ago • 2 comments

Proposed changes

  • Add test to make sure to spot unexpected import with labels
  • Add test to make sure to spot unexpected import with kill chain phases

Related issues

  • https://github.com/OpenCTI-Platform/opencti/issues/7036

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [ ] Where necessary I refactored code to improve the overall quality

Further comments

Goumies avatar Jun 28 '24 10:06 Goumies

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.62%. Comparing base (6289b3d) to head (97985bc). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7514      +/-   ##
==========================================
+ Coverage   67.59%   67.62%   +0.03%     
==========================================
  Files         567      567              
  Lines       69883    69883              
  Branches     5929     5935       +6     
==========================================
+ Hits        47235    47257      +22     
+ Misses      22648    22626      -22     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 28 '24 11:06 codecov[bot]

Is it possible to put at least a valid_from date in the tests ? It is required in indicators

SarahBocognano avatar Jul 01 '24 14:07 SarahBocognano

Is it possible to put at least a valid_from date in the tests ? It is required in indicators

@SarahBocognano, Are you sure? It is not required in the CSV mapper form. image

Goumies avatar Jul 09 '24 10:07 Goumies