opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[frontend] Fix [Bulk search] Sorting on the columns doesn't work (#7215)

Open SarahBocognano opened this issue 1 year ago • 6 comments

Proposed changes

  • Adapt the reversedBy function
  • Change resolvedStixCoreObjects field "containersNumber.total" to "analyses" for the sort to be taken into account.

Related issues

  • https://github.com/OpenCTI-Platform/opencti/issues/7215

Checklist

  • [ ] I consider the submitted work as finished
  • [ ] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [ ] Where necessary I refactored code to improve the overall quality

Further comments

SarahBocognano avatar Jun 28 '24 10:06 SarahBocognano

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.56%. Comparing base (d401814) to head (f9adb79).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7513   +/-   ##
=======================================
  Coverage   67.55%   67.56%           
=======================================
  Files         567      567           
  Lines       69903    69903           
  Branches     5937     5937           
=======================================
+ Hits        47226    47231    +5     
+ Misses      22677    22672    -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 28 '24 10:06 codecov[bot]

Nothing to do with sorting, but can you fix this in your PR : when no author, a '-' should be displayed instead of nothing (like for creation date) image

Archidoit avatar Jul 01 '24 06:07 Archidoit

Nothing is displayed in the 'creation date' column whereas entities have a creation date image

Archidoit avatar Jul 01 '24 06:07 Archidoit

When you pass the mouse on the 'label' column title, the mouse should be a pointer and not a 'clickable' hand icon. (see exemple when the mouse hovers the label column title in the reports list)

Archidoit avatar Jul 01 '24 06:07 Archidoit

Update: Comments fixed

SarahBocognano avatar Jul 01 '24 08:07 SarahBocognano

Everything is ok 👍 just waiting for the tests to pass

Archidoit avatar Jul 01 '24 13:07 Archidoit