opencti
opencti copied to clipboard
[frontend] Modifies autocomplete which causes form visual validation discrepancy
Proposed changes
- The fix to the following issue (https://github.com/OpenCTI-Platform/opencti/issues/5741) introduced a code change in commit (https://github.com/OpenCTI-Platform/opencti/commit/830f8a6#diff-41901d9dfd3a5b179fe6b41d020dd46b8c40be2fed3db788e2b4d4f9f021df42)
- This change created an inconsistency in form validation behavior when a required field relies on the AutoCompletedField component. This inconsistency is discussed/described in this issue (https://github.com/OpenCTI-Platform/opencti/issues/7401)
This PR seeks to standardize the form validation behavior on required fields to flag all in red via Formik validation, even fields that depend on the AutoCompletedField component.
Related issues
- N/A
Checklist
- [X] I consider the submitted work as finished
- [X] I tested the code for its functionality
- [X] N/A - I wrote test cases for the relevant uses case (coverage and e2e)
- [X] N/A - I added/update the relevant documentation (either on github or on notion)
- [X] Where necessary I refactored code to improve the overall quality
Further comments
None
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.55%. Comparing base (
3355b5f) to head (80bb754).
Additional details and impacted files
@@ Coverage Diff @@
## master #7437 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 567 567
Lines 69903 69903
Branches 5936 5936
=======================================
Hits 47223 47223
Misses 22680 22680
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.