[backend] Trigger enrichment connectors with filters (#5371)
Proposed changes
- define connector_trigger_filters
- filter enrichment connectors
Related issues
- #5371
Checklist
- [ ] I consider the submitted work as finished
- [ ] I tested the code for its functionality
- [ ] I wrote test cases for the relevant uses case (coverage and e2e)
- [ ] I added/update the relevant documentation (either on github or on notion)
- [ ] Where necessary I refactored code to improve the overall quality
Further comments
Codecov Report
Attention: Patch coverage is 53.68421% with 44 lines in your changes missing coverage. Please review.
Project coverage is 67.43%. Comparing base (
5319e8a) to head (e1fd86e).
Additional details and impacted files
@@ Coverage Diff @@
## master #7137 +/- ##
==========================================
- Coverage 67.45% 67.43% -0.03%
==========================================
Files 561 561
Lines 69258 69349 +91
Branches 5869 5882 +13
==========================================
+ Hits 46717 46764 +47
- Misses 22541 22585 +44
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just a detail, but maybe the filter box could be moved just a bit down? The 'Add filter' text goes a bit onto the 'Trigger filters' text when we click on the filter box
What's the expected behavior when auto is set to true in import-external-reference? Does it still take into account the trigger filters?
What's the expected behavior when auto is set to true in import-external-reference? Does it still take into account the trigger filters?
When trigger filters are set, it overrides the "auto" configuration, it will always trigger automatically the connector based on the filters, whether it was set to manual or automatic.
all comments have been fixed, waiting for review & approval