opencti icon indicating copy to clipboard operation
opencti copied to clipboard

[frontend] Add content mapping in content tab (#5651)

Open marieflorescontact opened this issue 1 year ago • 2 comments

  • remove content mapping from knowledge Tab for container
  • add content mapping in content Tab for Grouping/Report/Cases
  • add root component to switch from content to content mapping in Tab content

Related issues

Checklist

  • [x] I consider the submitted work as finished
  • [x] I tested the code for its functionality
  • [ ] I wrote test cases for the relevant uses case (coverage and e2e)
  • [ ] I added/update the relevant documentation (either on github or on notion)
  • [ ] Where necessary I refactored code to improve the overall quality

Further comments

marieflorescontact avatar May 27 '24 14:05 marieflorescontact

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.21%. Comparing base (08932ab) to head (65fa491). Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7136      +/-   ##
==========================================
+ Coverage   67.75%   68.21%   +0.45%     
==========================================
  Files         561      561              
  Lines       68824    68891      +67     
  Branches     5871     6460     +589     
==========================================
+ Hits        46631    46992     +361     
+ Misses      22193    21899     -294     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 30 '24 05:05 codecov[bot]

Description seem to be always empty in content mapping view (tested for serveral reports)

Capture d'écran 2024-05-30 153052

image

Even content is empty, when trying to create a report with a content, and selecting "create and map", the content mapping view displays empty content.

SouadHadjiat avatar May 30 '24 13:05 SouadHadjiat

Description seem to be always empty in content mapping view (tested for serveral reports)

Fixed

marieflorescontact avatar May 31 '24 14:05 marieflorescontact

all comments have been taken into account, ready for another review

marieflorescontact avatar May 31 '24 15:05 marieflorescontact

I'm wondering about the icon used in content for content view which is the same as for graph view, but we only display the content (content & files), shouldn't we use another icon?

image

SouadHadjiat avatar Jun 06 '24 12:06 SouadHadjiat

I'm wondering about the icon used in content for content view which is the same as for graph view, but we only display the content (content & files), shouldn't we use another icon?

image

yes we should definitly use another icon :) @nino-filigran

marieflorescontact avatar Jun 06 '24 12:06 marieflorescontact

Can't we use a toggle? Since the action is more to "enable/disable" a mode @marieflorescontact

nino-filigran avatar Jun 06 '24 12:06 nino-filigran

Can't we use a toggle? Since the action is more to "enable/disable" a mode @marieflorescontact

as discussed with @nino-filigran we will use : image

marieflorescontact avatar Jun 06 '24 13:06 marieflorescontact

all comments have been taken into account, ready for another review

marieflorescontact avatar Jun 06 '24 13:06 marieflorescontact

Content mapping view works all right ✅

However there seem to be a padding issue here :

image

image

SouadHadjiat avatar Jun 07 '24 14:06 SouadHadjiat

There is an issue now in reports -> knowledge, the graph should take the whole width :

image

SouadHadjiat avatar Jun 10 '24 08:06 SouadHadjiat

There is an issue now in reports -> knowledge, the graph should take the whole width :

fixed

marieflorescontact avatar Jun 11 '24 14:06 marieflorescontact

all comments have been taken into account, ready for another review

marieflorescontact avatar Jun 11 '24 14:06 marieflorescontact

image

SouadHadjiat avatar Jun 11 '24 15:06 SouadHadjiat

"knowledge" tab is not selected here in threat actor group

image

SouadHadjiat avatar Jun 11 '24 15:06 SouadHadjiat

Feedback has a content mapping button : Capture d'écran 2024-06-12 102903

And infrastructure doesn't have "knowledge" current tab selected: Capture d'écran 2024-06-12 103134

SouadHadjiat avatar Jun 12 '24 12:06 SouadHadjiat

all comments have been taken into account, ready for another review

marieflorescontact avatar Jun 12 '24 13:06 marieflorescontact

just found another one with wrong padding:

image

But it's actually already like this in production, so not a regression of this PR

SouadHadjiat avatar Jun 12 '24 15:06 SouadHadjiat