[frontend] Add content mapping in content tab (#5651)
- remove
content mappingfrom knowledge Tab for container - add
content mappingin content Tab for Grouping/Report/Cases - add root component to switch from
contenttocontent mappingin Tab content
Related issues
Checklist
- [x] I consider the submitted work as finished
- [x] I tested the code for its functionality
- [ ] I wrote test cases for the relevant uses case (coverage and e2e)
- [ ] I added/update the relevant documentation (either on github or on notion)
- [ ] Where necessary I refactored code to improve the overall quality
Further comments
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.21%. Comparing base (
08932ab) to head (65fa491). Report is 8 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #7136 +/- ##
==========================================
+ Coverage 67.75% 68.21% +0.45%
==========================================
Files 561 561
Lines 68824 68891 +67
Branches 5871 6460 +589
==========================================
+ Hits 46631 46992 +361
+ Misses 22193 21899 -294
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description seem to be always empty in content mapping view (tested for serveral reports)
Even content is empty, when trying to create a report with a content, and selecting "create and map", the content mapping view displays empty content.
Description seem to be always empty in content mapping view (tested for serveral reports)
Fixed
all comments have been taken into account, ready for another review
I'm wondering about the icon used in content for content view which is the same as for graph view, but we only display the content (content & files), shouldn't we use another icon?
I'm wondering about the icon used in content for content view which is the same as for graph view, but we only display the content (content & files), shouldn't we use another icon?
yes we should definitly use another icon :) @nino-filigran
Can't we use a toggle? Since the action is more to "enable/disable" a mode @marieflorescontact
Can't we use a toggle? Since the action is more to "enable/disable" a mode @marieflorescontact
as discussed with @nino-filigran we will use :
all comments have been taken into account, ready for another review
Content mapping view works all right ✅
However there seem to be a padding issue here :
There is an issue now in reports -> knowledge, the graph should take the whole width :
There is an issue now in reports -> knowledge, the graph should take the whole width :
fixed
all comments have been taken into account, ready for another review
"knowledge" tab is not selected here in threat actor group
Feedback has a content mapping button :
And infrastructure doesn't have "knowledge" current tab selected:
all comments have been taken into account, ready for another review
just found another one with wrong padding:
But it's actually already like this in production, so not a regression of this PR
